Merged
Conversation
SeanTAllen
added
the
changelog - added
ponylang-main
added
the
discuss during sync
SeanTAllen
removed
the
changelog - added
SeanTAllen
force-pushed
the
sean/add-equality-on-rows-row-field
branch
from
77d23da to
c19aeb7
Compare
Implement Equatable on Field, Row, and Rows val classes to enable == and != comparisons. Field.eq compares name and value, matching on all 8 FieldDataTypes variants. Row.eq and Rows.eq do ordered element-wise comparison — field/row order matters. Tests include both example-based tests (reflexive, structural, symmetric equality plus targeted inequality cases) and PonyCheck property tests that verify invariants across randomly generated values. This was item #33 in the project roadmap (discussion #72) and removes the TODO that was in rows.pony requesting this feature.
SeanTAllen
force-pushed
the
sean/add-equality-on-rows-row-field
branch
from
3877425 to
7b9f27f
Compare
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
EquatableonField,Row, andRowsval classes, enabling==/!=comparisons.Field.eqcompares name and value, matching on all 8FieldDataTypesvariantsRow.eqdoes element-wise field comparisonRows.eqdoes element-wise row comparisonrows.ponythat requested this featureItem #33 from the roadmap (discussion #72).